[Dspace-tech] additions module dependency on dspace-api

[Terry Brady]

I am starting our upgrade from DSpace 4 to DSpace 5.

Our code base contains only the dspace folder rather than the full source
distribution (dspace, dspace-api, etc).

All of our custom code resides in dspace/modules including
dspace/modules/additions.

Our additions module has a compile dependency on dspace-api and will not
compile unless dspace-api-5.4-SNAPSHOT.jar has already been installed in
the maven repository.

I can work around this issue by building the full source instance of DSpace
with mvn install and then running mvn package on my code base. I do not
remember encountering this issue on prior upgrades.

Here is an excerpt from my additions pom.xml file. Should I convey this
dependency differently?

<dependency>
<groupId>org.dspace</groupId>
<artifactId>dspace-api</artifactId>
</dependency>
<dependency>
<groupId>org.dspace</groupId>
<artifactId>dspace-api-lang</artifactId>
</dependency>
<dependency>
<groupId>javax.servlet</groupId>
<artifactId>servlet-api</artifactId>
<scope>provided</scope>
</dependency>

Thanks, Terry

[Andrea Schweer]

Hi Terry,

Post by Terry Brady
I am starting our upgrade from DSpace 4 to DSpace 5.
Our code base contains only the dspace folder rather than the full
source distribution (dspace, dspace-api, etc).
All of our custom code resides in dspace/modules including
dspace/modules/additions.
Our additions module has a compile dependency on dspace-api and will
not compile unless dspace-api-5.4-SNAPSHOT.jar has already been
installed in the maven repository.

Is there a particular reason you're doing the upgrade work against
(unreleased, may never happen) version 5.4? Your issue with having to
build dspace-api separately would go away if you worked against DSpace
5.3, since maven could then retrieve dspace-api, dspace-xmlui etc from
maven central. With your code set-up, the DSpace version is set in
dspace/pom.api.

cheers,
Andrea

[Terry Brady]

Andrea,

Thank you for the reply.

I merged my code from the dspace-5_x branch rather than from the dspace-5.3
release tag.

I will update my references to version 5.3.

Terry

Post by Andrea Schweer
Hi Terry,

Post by Terry Brady
I am starting our upgrade from DSpace 4 to DSpace 5.
Our code base contains only the dspace folder rather than the full source
distribution (dspace, dspace-api, etc).
All of our custom code resides in dspace/modules including
dspace/modules/additions.
Our additions module has a compile dependency on dspace-api and will not
compile unless dspace-api-5.4-SNAPSHOT.jar has already been installed in
the maven repository.

Is there a particular reason you're doing the upgrade work against
(unreleased, may never happen) version 5.4? Your issue with having to build
dspace-api separately would go away if you worked against DSpace 5.3, since
maven could then retrieve dspace-api, dspace-xmlui etc from maven central.
With your code set-up, the DSpace version is set in dspace/pom.api.
cheers,
Andrea
--
Dr Andrea Schweer
IRR Technical Specialist, ITS Information Systems
The University of Waikato, Hamilton, New Zealand